Improve error messages #1134
Open
Improve error messages #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/better-error-messages
branch
from
92d764e to
cca9d7d
Compare
csillag
force-pushed
the
csillag/better-error-messages
branch
from
cca9d7d to
2504455
Compare
lukaw3d
reviewed
Jan 11, 2024
| @@ -152,6 +152,8 @@ | |||
| "value": "{{value, number}}" | |||
| }, | |||
| "errors": { | |||
| "canNotLoadData": "Can not load data", | |||
| "canNotReachDataSource": "We were unable to reach the data source to request this data. This is probably a temporary (network?) problem. Please try again later.", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Friendly reminder: this is waiting for input from @donouwens
lukaw3d
reviewed
Jan 11, 2024
| data: 'not found', | ||
| headers: {}, | ||
| }) | ||
| return undefined |
There was a problem hiding this comment.
Future API will probably return 404 comparable to: https://nexus.oasis.io/v1/emerald/transactions/61c977e15629c030e05d831beaf228c374c7f1bc0dacf032a2c3c428afebf8b1
Comment on lines
+43
to
+44
| // TODO: look for other error codes, too. | ||
| // (Currently we are not aware of anything else) |
There was a problem hiding this comment.
Others: https://github.com/axios/axios/blob/6d4c421/README.md#error-types
ETIMEDOUT, ECONNABORTED, ERR_BAD_RESPONSE would indicate backend issue
Always try to properly differentiate between: - Illegal request (wrong address etc) - Failure to load data - Data not found
csillag
force-pushed
the
csillag/better-error-messages
branch
from
2504455 to
fe7fce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always try to properly differentiate between: